Allow setting the slave name, default to the fqdn at runtime #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the jar without name will automatically use the fqdn as name so no need to set it to the fqdn, and it's a problem when building images as the name is preset for any instance.
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
rtyler
pushed a commit
that referenced
this pull request
Sep 23, 2014
Allow setting the slave name, default to the fqdn at runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the jar without name will automatically use the fqdn as name
so no need to set it to the fqdn, and it's a problem when building images
as the name is preset for any instance.